Fix items with different mods getting stacked together #52252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Maleclypse
added
<Bugfix>
|
There are some dissimilar items that do stack and presumably are intended to stack, such as survivor notes. It would probably be good to check that they still stack even if they have different texts on them. |
|
Nothing in the code suggests that would be the case, and a sanity check shows that items without mods (+1, +2, etc.) still stack normally: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
None
Purpose of change
Fixes #52251.
Describe the solution
Check item mods when comparing two items. This prevents items with different mods from being stacked together if they are otherwise identical. This fix applies to all item screens that use
item::stacks_with().Describe alternatives you've considered
Testing
gor through AIMAdditional context